copy Whisper generate_with_fallback kwargs#29434
Closed
udeepam wants to merge 2 commits intohuggingface:mainfrom
Closed
copy Whisper generate_with_fallback kwargs#29434udeepam wants to merge 2 commits intohuggingface:mainfrom
udeepam wants to merge 2 commits intohuggingface:mainfrom
Conversation
udeepam
changed the title
udeepam
changed the title
Contributor
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
Collaborator
|
I think this was fixed by #29225 |
Contributor
|
This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Please note that issues that do not follow the contributing guidelines are likely to be ignored. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The Whisper longform audio decoding strategy (from the paper) is for each audio segment:
GenerationMode.BEAM_SEARCHGenerationMode.SAMPLEHowever because the
kwargstogenerate_with_fallback()are not copied, if on the first audio segment we fallback thenum_beamsparameter in thekwargsget removed.transformers/src/transformers/models/whisper/generation_whisper.py
Line 777 in 1681a6d
Hence for the second audio segment we start with
GenerationMode.SAMPLEinstead ofGenerationMode.BEAM_SEARCH.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@sanchit-gandhi